feat(agent): add scenario input model and assumptions - #358
Merged
JSONbored merged 3 commits intoJun 4, 2026
Conversation
Define deterministic agent scenario inputs with fact/assumption/estimate/unavailable buckets, public-safe serialization, and fail-closed local branch metadata guards. Fixes JSONbored#286
JSONbored
approved these changes
Jun 4, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@kiannidev this looks ready from this pass.
A few notes:
- The scenario input model is cleanly scoped to shared planning data and does not overreach into ranking or autonomous behavior.
- The public/private serializers and source-upload guard are the right safety boundaries.
- The PR body includes the full validation matrix and a clear skipped-check rationale.
No code changes are requested from this review pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286
Summary
src/scenarios/input-model.ts— deterministic agent scenario input model for repo-specific planning before individual simulations.buildScenarioInput,parseAgentScenarioInput,serializeScenarioInputPublic, andserializeScenarioInputPrivatehelpers safe for MCP/API use.assertScenarioLocalBranchInputSafe) and public-safe serialization (no wallet/hotkey/trust-score/payout/farming language).Scope
CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
Verified locally with
npm run test:cion Node v24.15.0 (repo requires Node >= 22 per.nvmrc).git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:raycastskipped — no Raycast package changes in this PR.New tests:
test/unit/scenario-input-model.test.ts— complete/partial/unavailable inputs, bucket kind validation, public vs private serialization, source-upload guard, forbidden-language property checks.Safety
Notes